Add gradient accumulation scheduler #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,4 +15,4 @@ model_config: | |||
| block_size: 2048 | |||
| vocab_size: 256000 | |||
| separator_token: <bos> | |||
| tokenizer_path: "chemlactica/tokenizer/GemmaTokenizer" | |||
| tokenizer_path: "/auto/home/menuab/code/ChemLactica/chemlactica/tokenizer/GemmaTokenizer" | |||
There was a problem hiding this comment.
Does the relative path break something here? If not, let's keep it.
There was a problem hiding this comment.
there was an issue with running from a notebook, should be okay now
There was a problem hiding this comment.
I missed this one, will fix with the next test run
| last_far_loss = [ | ||
| s["loss"] | ||
| for s in state.log_history[ | ||
| -20 * self.ga_delta_steps : -19 * self.ga_delta_steps # noqa |
There was a problem hiding this comment.
-20 and -19 seem like magic values. Can we either have them as named constants or add a comment?
There was a problem hiding this comment.
good idea, comments added
submit_run.py
Outdated
There was a problem hiding this comment.
Thanks for cleaning this up, these are very nice defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds gradient accumulation scheduler