Mol opt #24
Merged
Mol opt #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MenuaB
reviewed
Apr 23, 2024
| return predicted_property_values | ||
|
|
||
|
|
||
| def optimize( |
There was a problem hiding this comment.
it is not clear where we call this optimize function and what the input model and config are. please push the code that runs this module.
MenuaB
reviewed
Apr 23, 2024
chemlactica/mol_opt/tunning.py
Outdated
There was a problem hiding this comment.
seems like this piece is redundant as we already have code for supervised fine tuning. Is there a way we can use the existing code base?
also it looks like this code is using the old config format, let's update this if possible as this won't match with our existing code base anymore.
MenuaB
reviewed
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.