Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Rust #10

Closed
wants to merge 5 commits into from
Closed

Conversation

Snapstromegon
Copy link

I believe that #6 contained many valid points and because of that I want to contribute the migration to rust. As @TheSamDickey mentioned, this is not an easy switch, but will likely improve the situation for all users and even more so the energy consumption.

The only possible downsides from a professional point of view right now are a requried build step for execution (handled easily via cargo run --release) and a slightly increased code complexity, which should be okay.

This PR introduces rust as a dependency for the project. Use rustup to install it in a convenient way.

closes #6

I believe that Yetiowner#6 contained many valid points and because of that I want to contribute the migration to rust.
As @TheSamDickey mentioned, this is not an easy switch, but will likely improve the situation for all users and even more so the energy consumption.
@floppydisken
Copy link

floppydisken commented Oct 19, 2022

The performance implications of staying close to the metal will be beneficial for the project overall. Arguably Rust is as readable as Python but blazingly fast. I second this PR. It really is the only sensible thing to do

Copy link
Owner

@Yetiowner Yetiowner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A: I will only make changes recommended on r/programmerhumour
B: Even if I didn't, there is a major functionality flaw. See src/main.rs line 2: You misspelled HelloWorld

@Snapstromegon
Copy link
Author

Snapstromegon commented Oct 19, 2022

For anyone stumbling upon this: You can currently vote for this PR here: https://www.reddit.com/r/ProgrammerHumor/comments/y97azd/comment/it482yg/?utm_source=share&utm_medium=web2x&context=3

@TheSamDickey
Copy link

Brilliant! This is a profound contribution that will be without a doubt impactful. I cannot imagine how many sleepless nights were sacrificed to accomplish such a high achievement.

Kudos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perhaps use Rust instead of Python to avoid installation issues?
4 participants