Extract base tag href for resolving asset URLs #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
My Grist package is marked as broken since package_check has checked the assets.
By taking a closer look, I realized that it wasn't an issue of my package, nor of the upstream app, but of the checker.
Indeed, the browser resolves assets (scripts and stylesheets) paths either from the domain, but also if present using the
<base>
tag (mdn documentation).Proposed solution
https://{domain}/path/to/
or a absolute path without the domain like/path/to/
).