Bookworm rebased #554
Closed
Bookworm rebased #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…option prop min + max
…n should still be valid
|
Not sure why the eslint job is failing with an empty log, and I can't even see any major diff with CI-related stuff in the diff 🤔 Anyway, LGTM, shall we force-push to bookworm ? |
|
Yep weird, the test is still with npm instead of yarn, but yes i can force push ; ) |
|
closed in favor of #530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hum could i force push this to the bookworm branch?
I separated some commits that could have been merged before, and apply lot of linting/migration based on dev branch so i can start working on the migration to vue3 without waiting for bookworm to be merged.