Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dump script log extract for debugging #1721

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

kay0u
Copy link
Member

@kay0u kay0u commented Oct 2, 2023

The problem

When a script fails, we get sometimes:

ERROR Could not upgrade gitlab: Something unexpected went wrong: 
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/yunohost/hook.py", line 538, in hook_exec_with_script_debug_if_failure
    operation_logger.dump_script_log_extract_for_debugging()
  File "/usr/lib/python3/dist-packages/yunohost/log.py", line 749, in dump_script_log_extract_for_debugging
    lines = [line.strip().split(": ", 1)[1] for line in lines]
  File "/usr/lib/python3/dist-packages/yunohost/log.py", line 749, in <listcomp>
    lines = [line.strip().split(": ", 1)[1] for line in lines]
IndexError: list index out of range

https://ci-apps-dev.yunohost.org/ci/job/10016

Solution

...

PR Status

...

How to test

...

@kay0u kay0u changed the base branch from dev to bookworm October 2, 2023 02:13
@alexAubin alexAubin force-pushed the fix-dump_script_log_extract_for_debugging branch from 8b8c552 to 7f954af Compare October 30, 2023 13:00
@alexAubin alexAubin merged commit 7c89c2c into bookworm Oct 30, 2023
@alexAubin alexAubin deleted the fix-dump_script_log_extract_for_debugging branch October 30, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants