Support paths using 2-byte characters #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following error occurs when the path contains 2-byte characters. ``` URI::InvalidURIError: URI must be ascii only "http://localhost:4567/\u732B" ``` Referring to the Capybara implementation, use Addressable instead of URI to support 2-byte characters. refs: https://github.com/teamcapybara/capybara/blob/3.40.0/lib/capybara/session.rb#L261
sinsoku
force-pushed
the
support-paths-using-2bytes
branch
from
22620fd
to
ef4cdc5
Compare
YusukeIwaki
reviewed
Feb 16, 2024
| elsif Capybara.default_host | ||
| URI(Capybara.default_host).merge(path) | ||
| Addressable::URI.parse(Capybara.default_host) + path |
There was a problem hiding this comment.
|
Thank you! |
|
CI failure will be fixed on another PR. I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error occurs when the path contains 2-byte characters.
Referring to the Capybara implementation, use Addressable instead of URI
to support 2-byte characters.
refs: https://github.com/teamcapybara/capybara/blob/3.40.0/lib/capybara/session.rb#L261