Pass user object to preprocess function. #483
Conversation
| @@ -132,10 +133,10 @@ protected function updateUserPasswordHash(UserEntity $user, $password, Bcrypt $b | |||
| $this->getMapper()->update($user); | |||
| } | |||
|
|
|||
| public function preprocessCredential($credential) | |||
| public function preprocessCredential($credential, UserEntity $user) | |||
There was a problem hiding this comment.
UserInterface is imported as UserEntity. I did not touch this, but this was already the case.
There was a problem hiding this comment.
We could resolve this in different PR?
There was a problem hiding this comment.
Ah, sorry about that. ZfcUser\Mapper\UserInterface will be renamed to UserMapperInterface in 2.0 which will resolve this "collision".
There was a problem hiding this comment.
Ah I see! So I guess I should leave it the way it is?
|
I am currently using this to to log on with legacy passwords and it works as expected. Would be great to have this merged. |
|
@Danielss89 |
|
I guess it's OK to merge. The other function already pass this if I'm not mistaken. Can't check atm as I'm on the phone. |
|
Any progress on this? |
|
This is for 2.0 which is still in the future, so i'll keep them as PR's until i'm ready to do more about it. |
|
Maybe this can be merged in now?### |
Currently I am trying to let users logon to ZfcUser using legacy passwords. I was thinking of doing so by using the preprocess function. However it fails in that regard.
For this to work I need to have a case distinction between old and new users. I obviously have that state in my
UserEntitymodel. There is however no way to access the user object at preprocessing time.Therefore this PR adds a second paramter to the function passing in the user object. I find the API to still be easy usable and this change is BC because passing in a callback using a single parameter is still valid.