Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple callback calls #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakedaleweb
Copy link

This library is incompatible with newer node versions (~16+) which throw an error when the callback is called more than once. The way this library currently works it is always going to call the callback within the close method and then in the then call afterwards resulting in

Error [ERR_MULTIPLE_CALLBACK]: Callback called multiple times
    at NodeError (node:internal/errors:400:5)
    at onFinish (node:internal/streams/writable:671:37)
    at node:internal/streams/transform:147:9
    at /app/node_modules/parquetjs-lite/lib/writer.js:321:18
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

In the process of testing this fix at the moment.. will report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant