Skip to content

Commit

Permalink
fix(ci): also check for duplicate dependencies with optional features…
Browse files Browse the repository at this point in the history
… off (#3592)

* fix(dependencies): update an unused duplicate dependency exception

This duplicate was removed by PR #3572, but other duplicates still exist.

* feat(ci): check for duplicate dependencies with optional features off
  • Loading branch information
teor2345 authored Feb 21, 2022
1 parent 2253f01 commit 1896943
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ jobs:
strategy:
matrix:
checks:
- bans
- bans
- sources

# Prevent sudden announcement of a new advisory from failing ci:
Expand All @@ -244,3 +244,10 @@ jobs:
with:
command: check ${{ matrix.checks }}
args: --all-features --workspace

# this check runs with optional features off
# so we expect some warnings about "skip tree root was not found"
- uses: EmbarkStudios/cargo-deny-action@v1
with:
command: check ${{ matrix.checks }}
args: --workspace
9 changes: 6 additions & 3 deletions deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ skip-tree = [
# ticket #2984: owo-colors dependencies
{ name = "color-eyre", version = "=0.5.11" },

# ticket #2998: hdrhistogram dependencies
{ name = "hdrhistogram", version = "=6.3.4" },

# ticket #3061: reqwest and minreq dependencies
{ name = "webpki-roots", version = "=0.18.0" },

Expand All @@ -59,6 +56,12 @@ skip-tree = [
# alternative: downgrade Zebra to `bigint`
{ name = "bigint", version = "=4.4.3" },

# upgrade sentry, metrics-exporter-prometheus, reqwest, hyper,
# which needs #2953: upgrade tracing to the latest major version
#
# also wait for tower-test and tokio-test to upgrade
{ name = "tokio-util", version = "=0.6.9" },

# recent major version bumps
# we should re-check these dependencies in February 2022

Expand Down

0 comments on commit 1896943

Please sign in to comment.