Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MotLK achievement logo and pack to main sets #301

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

piedpiper358
Copy link
Contributor

@piedpiper358 piedpiper358 commented Nov 11, 2022

You should also add images and boosterId for new packs:

  • March of the Lich King pack (only image)
  • Signature Golden March of the Lich King pack
  • Death Knight pack

2022-11-11_23-09-17

@sebastientromp
Copy link
Contributor

Is the logo used anywhere?

And there are conflicts in the PR, if you could have a look :)

@piedpiper358
Copy link
Contributor Author

In theory, this logo should be used in achievements. By the way, would you mind to add the correct identifiers so that logos I added earlier show up in achievements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants