Feat/sig format #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chcmedeiros
commented
Jan 26, 2024
chcmedeiros
commented
- add fuzzer fixes
- signature in rsv format, similar to the object returned by the signEthTransaction
- rename ETH methods to EVM
ftheirs
reviewed
Jan 26, 2024
chcmedeiros
force-pushed
the
feat/sig-format
branch
2 times, most recently
from
f797767
to
8573537
Compare
ftheirs
approved these changes
Jan 26, 2024
| @@ -107,9 +109,13 @@ export default class FlareApp extends GenericApp { | |||
| } | |||
|
|
|||
| if (returnCode === LedgerError.NoErrors && response.length > 2) { | |||
| signature = response.slice(0, response.length - 2); | |||
| r = response.subarray(0, 32); | |||
chcmedeiros
force-pushed
the
feat/sig-format
branch
from
8573537
to
42d85e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.