Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymesh upgrade v7 #111

Merged
merged 13 commits into from
Oct 28, 2024
Merged

Polymesh upgrade v7 #111

merged 13 commits into from
Oct 28, 2024

Conversation

0xPxt
Copy link
Contributor

@0xPxt 0xPxt commented Oct 17, 2024

Resolving the following issues :
#108
#109
#110

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2024
View reviewed changes
app/src/substrate/substrate_strings.h
@@ -380,6 +380,8 @@
static const char* STR_ME_REMOVE_TICKER_AFFIRMATION_EXEMPTION = "Remove ticker affirmation exemption";
static const char* STR_ME_PRE_APPROVE_TICKER = "Pre approve ticker";
static const char* STR_ME_REMOVE_TICKER_PRE_APPROVAL = "Remove ticker pre approval";
static const char* STR_ME_AS_DERIVATIVE = "As derivative";

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable STR_ME_AS_DERIVATIVE is never read.
app/src/substrate/substrate_strings.h
@@ -380,6 +380,8 @@
static const char* STR_ME_REMOVE_TICKER_AFFIRMATION_EXEMPTION = "Remove ticker affirmation exemption";
static const char* STR_ME_PRE_APPROVE_TICKER = "Pre approve ticker";
static const char* STR_ME_REMOVE_TICKER_PRE_APPROVAL = "Remove ticker pre approval";
static const char* STR_ME_AS_DERIVATIVE = "As derivative";
static const char* STR_ME_UNLINK_TICKER_FROM_ASSET_ID = "Unlink ticker from asset id";

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable STR_ME_UNLINK_TICKER_FROM_ASSET_ID is never read.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 24, 2024
View reviewed changes
app/src/substrate/substrate_dispatch_V7.c Outdated
Comment on lines 5190 to 5195
switch (itemIdx) {
case 0:
return STR_IT_new_;
default:
return NULL;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
app/src/substrate/substrate_dispatch_V7.c
Comment on lines +5533 to +5538
switch (itemIdx) {
case 0:
return STR_IT_maybe_next_score;
default:
return NULL;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
app/src/substrate/substrate_dispatch_V7.c
Comment on lines +5540 to +5545
switch (itemIdx) {
case 0:
return STR_IT_supports;
default:
return NULL;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
app/src/substrate/substrate_dispatch_V7.c
Comment on lines +5547 to +5552
switch (itemIdx) {
case 0:
return STR_IT_raw_solution;
default:
return NULL;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
app/src/substrate/substrate_dispatch_V7.c
Comment on lines +8217 to +8225
switch (itemIdx) {
case 0: /* sudo_set_key_V7 - new_ */;
return _toStringLookupasStaticLookupSource(
&m->basic.sudo_set_key_V7.new_,
outValue, outValueLen,
pageIdx, pageCount);
default:
return parser_no_data;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
app/src/substrate/substrate_dispatch_V7.c
Comment on lines +8827 to +8835
switch (itemIdx) {
case 0: /* electionprovidermultiphase_set_minimum_untrusted_score_V7 - maybe_next_score */;
return _toStringOptionElectionScore(
&m->basic.electionprovidermultiphase_set_minimum_untrusted_score_V7.maybe_next_score,
outValue, outValueLen,
pageIdx, pageCount);
default:
return parser_no_data;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
app/src/substrate/substrate_dispatch_V7.c
Comment on lines +8837 to +8845
switch (itemIdx) {
case 0: /* electionprovidermultiphase_set_emergency_election_result_V7 - supports */;
return _toStringSupportsAccountId(
&m->basic.electionprovidermultiphase_set_emergency_election_result_V7.supports,
outValue, outValueLen,
pageIdx, pageCount);
default:
return parser_no_data;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
app/src/substrate/substrate_dispatch_V7.c
Comment on lines +8847 to +8855
switch (itemIdx) {
case 0: /* electionprovidermultiphase_submit_V7 - raw_solution */;
return _toStringBoxRawSolutionSolutionOfMinerConfig(
&m->basic.electionprovidermultiphase_submit_V7.raw_solution,
outValue, outValueLen,
pageIdx, pageCount);
default:
return parser_no_data;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
@0xPxt 0xPxt force-pushed the polymesh-upgradev7 branch 2 times, most recently from d7557c5 to aec6b80 Compare October 28, 2024 13:54
@0xPxt 0xPxt changed the base branch from main to dev October 28, 2024 16:50
@0xPxt 0xPxt merged commit 8bce030 into dev Oct 28, 2024
58 checks passed
@0xPxt 0xPxt deleted the polymesh-upgradev7 branch October 28, 2024 16:50
0xPxt added a commit that referenced this pull request Oct 28, 2024
@0xPxt
Merge pull request #112 from Zondax/dev
87a5f0f 
Polymesh upgrade v7 (#111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neithanmo neithanmo neithanmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xPxt @neithanmo