Skip to content

Commit

Permalink
perf: avoid duplicate FinalityUpdate in ChainWatcher (#180)
Browse files Browse the repository at this point in the history
optimize l1 chain watcher
  • Loading branch information
LEAFERx authored Nov 27, 2023
1 parent 8dc333c commit 5e14808
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions src/l1/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,17 @@ impl InnerWatcher {
if self.current_block > self.finalized_block {
let finalized_block = self.get_finalized().await?;

self.finalized_block = finalized_block;
self.block_update_sender
.send(BlockUpdate::FinalityUpdate(finalized_block))
.await?;

self.unfinalized_blocks
.retain(|b| b.number > self.finalized_block)
// Only update finalized block if it has changed to avoid spamming the channel.
if self.finalized_block < finalized_block {
tracing::debug!("[l1] finalized block updated to {}", finalized_block);
self.finalized_block = finalized_block;
self.block_update_sender
.send(BlockUpdate::FinalityUpdate(finalized_block))
.await?;

self.unfinalized_blocks
.retain(|b| b.number > self.finalized_block)
}
}

if self.current_block > self.head_block {
Expand Down

0 comments on commit 5e14808

Please sign in to comment.