Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driver): Graceful HeadInfo Fetching #160

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 1, 2023

Description

Refactors out the HeadInfo fetching from inside the Driver's from_config method.

This allows us to unit test head info fetching by wrapping the provider in a minimal trait.

@refcell
Copy link
Collaborator Author

refcell commented Sep 1, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@refcell refcell self-assigned this Sep 1, 2023
@refcell refcell requested a review from ncitron September 1, 2023 21:44
Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit ad2fa0d into master Sep 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants