This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Validate event properties #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I guess the tests are flaky... |
millerf
reviewed
Oct 30, 2024
| with: | ||
| path: ${{ steps.wp_env_dir.outputs.WPENV_DIR }} | ||
| key: ${{ runner.os }}-${{ hashFiles('**/.wp-env.json') }} | ||
| # - name: Cache wp-env |
There was a problem hiding this comment.
@n3f Is that change necessary? If so, should it be removed?
There was a problem hiding this comment.
So the builds were failing with this in for some reason. I'm not sure if it created a timeout or if the cache was bad or what. I left the comment in because it seems like it should work (and it did work for several builds - then it broke for several). Since I removed it, all the builds have been working correctly.
millerf
reviewed
Oct 30, 2024
| @@ -120,7 +126,7 @@ public static function login_failure( string $username, \WP_Error $error ) { | |||
| $failure_reason = null; | |||
| } | |||
| $properties = array( | |||
| '$user_id' => $attempted_user->ID ? $attempted_user->ID : null, | |||
| '$user_id' => (string) $attempted_user->ID ?? null, | |||
There was a problem hiding this comment.
Doesn't $attempted_user->ID ?? null on (string)?
I am always confused with that...
millerf
approved these changes
Oct 30, 2024
added 14 commits
October 30, 2024 09:44
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/gold/issues/525
Changes proposed in this Pull Request
Testing instructions
wp-env(e.g.npm i && composer install && npx wp-env start)npm run test