Skip to content

Commit

Permalink
Remove commented-out section of deploy workflow referencing ECS deplo…
Browse files Browse the repository at this point in the history
…yment with Amazon workflows
  • Loading branch information
Aaron Carlucci committed Nov 28, 2023
1 parent a2fcc6d commit a66fece
Showing 1 changed file with 0 additions and 37 deletions.
37 changes: 0 additions & 37 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,40 +111,3 @@ jobs:
-var="image_tag=${{ github.sha }}" \
-var="vpc_cidr_index=${{ inputs.vpc_cidr_index }}"
working-directory: ./terraform

# # Docker section
# - name: Login to AWS ECR
# id: login-ecr
# uses: aws-actions/aws-ecr-login@v2

# - name: Build, tag and push docker image to ECR
# id: build-image
# env:
# REGISTRY: ${{ steps.login-ecr.outputs.registry }}
# REPOSITORY: "${{ steps.terraform-apply.outputs.namespace }}/hello-world"
# IMAGE_TAG: ${{ github.sha }}
# run: |
# docker build -t $REGISTRY/$REPOSITORY:$IMAGE_TAG .
# docker push $REGISTRY/$REPOSITORY:$IMAGE_TAG
# echo "image=$ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG" >> $GITHUB_OUTPUT

# - name: Download task definition
# run: |
# aws ecs describe-task-definition --task-definition ${{ steps.terraform-apply.outputs.namespace }}-hello-world \
# --query taskDefinition > task-definition.json

# - name: Fill in the new image ID in the Amazon ECS task definition
# id: task-definition
# uses: aws-actions/amazon-ecs-render-task-definition@v1
# with:
# task-definition: task-definition.json
# container-name: hello-world
# image: ${{ steps.build-image.outputs.image }}

# - name: Deploy Amazon ECS task definition
# uses: aws-actions/amazon-ecs-deploy-task-definition@v1
# with:
# task-definition: ${{ steps.task-definition.outputs.task-definition }}
# service: ${{ steps.terraform-apply.outputs.namespace }}-hello-world
# cluster: ${{ steps.terraform-apply.outputs.namespace }}
# wait-for-service-stability: true

0 comments on commit a66fece

Please sign in to comment.