Merge new updates into main branch #33
Annotations
2 errors and 10 warnings
shellcheck
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
shellcheck
Process completed with exit code 2.
|
shellcheck:
get-last-status.sh#L20
[shellcheck] reported by reviewdog 🐶
Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.
Raw Output:
./get-last-status.sh:20:19: warning: Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames. (ShellCheck.SC2010)
|
shellcheck:
get-last-status.sh#L21
[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.
Raw Output:
./get-last-status.sh:21:31: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
|
shellcheck:
zfs-replicate.sh#L19
[shellcheck] reported by reviewdog 🐶
Declare and assign separately to avoid masking return values.
Raw Output:
./zfs-replicate.sh:19:23: warning: Declare and assign separately to avoid masking return values. (ShellCheck.SC2155)
|
shellcheck:
zfs-replicate.sh#L22
[shellcheck] reported by reviewdog 🐶
Declare and assign separately to avoid masking return values.
Raw Output:
./zfs-replicate.sh:22:23: warning: Declare and assign separately to avoid masking return values. (ShellCheck.SC2155)
|
shellcheck:
zfs-replicate.sh#L50
[shellcheck] reported by reviewdog 🐶
exit_clean references arguments, but none are ever passed.
Raw Output:
./zfs-replicate.sh:50:1: warning: exit_clean references arguments, but none are ever passed. (ShellCheck.SC2120)
|
shellcheck:
zfs-replicate.sh#L84
[shellcheck] reported by reviewdog 🐶
Declare and assign separately to avoid masking return values.
Raw Output:
./zfs-replicate.sh:84:15: warning: Declare and assign separately to avoid masking return values. (ShellCheck.SC2155)
|
shellcheck:
zfs-replicate.sh#L86
[shellcheck] reported by reviewdog 🐶
Declare and assign separately to avoid masking return values.
Raw Output:
./zfs-replicate.sh:86:15: warning: Declare and assign separately to avoid masking return values. (ShellCheck.SC2155)
|
shellcheck:
zfs-replicate.sh#L86
[shellcheck] reported by reviewdog 🐶
Consider using pgrep instead of grepping ps output.
Raw Output:
./zfs-replicate.sh:86:21: info: Consider using pgrep instead of grepping ps output. (ShellCheck.SC2009)
|
shellcheck:
zfs-replicate.sh#L86
[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.
Raw Output:
./zfs-replicate.sh:86:35: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
|
shellcheck:
zfs-replicate.sh#L123
[shellcheck] reported by reviewdog 🐶
Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
Raw Output:
./zfs-replicate.sh:123:14: info: Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. (ShellCheck.SC2181)
|
Loading