Skip to content

Commit

Permalink
snapSend fuction needs to account for the RECURSE_CHILDREN=1 or =0
Browse files Browse the repository at this point in the history
  • Loading branch information
tschettervictor authored Aug 26, 2024
1 parent 7d1dd4c commit dc65b62
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions zfs-replicate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,14 @@ snapSend() {
checkLock "$TMPDIR/.replicate.send.lock"
## create initial send command based on arguments
## if first snap name is not empty generate an incremental
local args="-R"
if [ -n "$base" ]; then
if [ ${RECURSE_CHILDREN} -eq 1 ]; then

Check warning on line 154 in zfs-replicate.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./zfs-replicate.sh:154:8: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
args="-R"
elif [ ${RECURSE_CHILDREN} -eq 0 ]; then

Check warning on line 156 in zfs-replicate.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./zfs-replicate.sh:156:10: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
args=""
elif [ -n "$base" ] && [ ${RECURSE_CHILDREN} -eq 1 ]; then

Check warning on line 158 in zfs-replicate.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./zfs-replicate.sh:158:28: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
args="-R -I $base"
elif [ -n "$base" ] && [ ${RECURSE_CHILDREN} -eq 0 ]; then

Check warning on line 160 in zfs-replicate.sh

View workflow job for this annotation

GitHub Actions / runner / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./zfs-replicate.sh:160:28: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
args="-I $base"
fi
## set the command prefix based on source host
local prefix
Expand Down

0 comments on commit dc65b62

Please sign in to comment.