Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(boto_minio): add minio client for object storage #1623

Merged
merged 2 commits into from
Nov 9, 2024
Merged

feat(boto_minio): add minio client for object storage #1623

merged 2 commits into from
Nov 9, 2024

Conversation

USA-RedDragon
Copy link
Contributor

In order to use Minio, I needed to set a custom endpoint. I noticed this was commented out, so I went ahead and wired it up.

@USA-RedDragon USA-RedDragon marked this pull request as draft November 9, 2024 00:23
@USA-RedDragon
Copy link
Contributor Author

Converting to draft. For the upload, the endpoint_url shouldn't contain the bucket name in the path, but the capture process sets the s3_prefix properly, so this patchset breaks uploads

@USA-RedDragon USA-RedDragon force-pushed the boto-s3-minio-support branch 2 times, most recently from 32a604d to eef8677 Compare November 9, 2024 00:39
@USA-RedDragon USA-RedDragon marked this pull request as ready for review November 9, 2024 00:39
@USA-RedDragon USA-RedDragon marked this pull request as draft November 9, 2024 00:40
@USA-RedDragon
Copy link
Contributor Author

Fixed with 8c45e22

@USA-RedDragon USA-RedDragon marked this pull request as ready for review November 9, 2024 00:43
@aaronwmorris
Copy link
Owner

What do you think about implementing this as a custom S3 Utility in the drop down and keep the origin AWS boto3 code as-is?

@USA-RedDragon
Copy link
Contributor Author

I've got zero issue with that, I'll pursue that direction. :)

@USA-RedDragon USA-RedDragon marked this pull request as draft November 9, 2024 00:58
@USA-RedDragon USA-RedDragon force-pushed the boto-s3-minio-support branch 2 times, most recently from 0cb0e0f to 760a0c1 Compare November 9, 2024 02:00
@USA-RedDragon USA-RedDragon marked this pull request as ready for review November 9, 2024 02:01
@USA-RedDragon USA-RedDragon changed the title fix(boto_s3): set endpoint based on URL template fix(boto_minio): add minio client for object storage Nov 9, 2024
@USA-RedDragon USA-RedDragon changed the title fix(boto_minio): add minio client for object storage feat(boto_minio): add minio client for object storage Nov 9, 2024
@aaronwmorris
Copy link
Owner

Looks good to me, I will merge if you are ready.

@USA-RedDragon
Copy link
Contributor Author

Just validated these changes, this one is good

@aaronwmorris aaronwmorris merged commit 8823fbe into aaronwmorris:main Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@USA-RedDragon @aaronwmorris