Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovertemplate breaks #191

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

bab9e9
Copy link

@bab9e9 bab9e9 commented May 20, 2020

Update hovertemplate to read better: numbers on left, more or less aligned in a column.

It's not perfect because the font being used doesn't have consistent width for digits comma and space.

Small error in a commit, doesn't matter in the end:
File was unsaved in VS code, so the commit at 666b7d9 wasn't quite the latest version.
So the commit message is "future", prophesying the name change in the next commit 937f9c0.
By the way:
The reason I changed the name was to avoid getting too concrete.
The name weeklyTotalExtra expresses the contents too much. If it was total, weekly, extra, then I would not want to change the name. So "hovertemplateBody" says that this is used in the hovertemplate:, but not exactly what is in it and what order.

@netlify
Copy link

netlify bot commented May 20, 2020

Deploy preview for frosty-benz-8c81bf ready!

Built without sensitive environment variables with commit 8982566

https://deploy-preview-191--frosty-benz-8c81bf.netlify.app

@MrSpiffyClean
Copy link
Contributor

Fixing the spacing issue could probably be done by <span>ing the case numbers and giving them the same width in CSS. Other than this, seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants