CCIP 1.5 Migration #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rade-remote-pool-fix
|
miguelmtzinf
force-pushed
the
ccip-gho
branch
from
c020802
to
d27d468
Compare
contracts/src/v0.8/ccip/pools/GHO/UpgradeableBurnMintTokenPool.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/pools/GHO/fork/GhoTokenPoolMigrate1_4To1_5/ForkBase.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/pools/GHO/fork/GhoTokenPoolMigrate1_4To1_5/TokenPoolsUpgrade.t.sol
Show resolved
Hide resolved
DhairyaSethi
added a commit
to aave/aave-proposals-v3
that referenced
this pull request
Oct 18, 2024
|
Changes look good to me. Thanks @DhairyaSethi |
| @@ -7,13 +7,13 @@ index f5eb135186..e228732855 100644 | |||
| // SPDX-License-Identifier: BUSL-1.1 | |||
| -pragma solidity 0.8.19; | |||
| +pragma solidity ^0.8.0; | |||
|
|
|||
|
|
|||
| -import {IBurnMintERC20} from "../../shared/token/ERC20/IBurnMintERC20.sol"; | |||
| +import {IBurnMintERC20} from "../../../shared/token/ERC20/IBurnMintERC20.sol"; | |||
There was a problem hiding this comment.
I think this happens becuse you are diffing X Y instead of Y X
There was a problem hiding this comment.
it's diffing the base token pool against the upgradable versions - the changes we added on top of chainlink's contracts, that seems right to me?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/51
CCIP is moving to 1.5, & existing GHO token pools on Ethereum & Arbitrum use 1.4. This PR intends add backward compatibility to existing token pools by explicitly allowing calls from the proxy pool in the
onlyOnRampmodifier. The proxyPool contract acts as a wrapper between new on ramp (1.5) and our token pool.This change is added in the base contract
UpgradableTokenPool.While making this contract upgradable, storage
__gappractice was overlooked and hence a custom storage slot is introduced for the proxy pool contract which is only settable by the DAO (no separate role is added for this).