improve tooling #165
Open
improve tooling #165
+638
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellourbani
commented
Sep 29, 2024
| @@ -40,7 +40,8 @@ class DefaultProvider implements FsProvider { | |||
| } | |||
|
|
|||
| public async glob(pattern: string) { | |||
| const found = sync(pattern, {nosort: true, nodir: true}); | |||
| const options = {nosort: true, nodir: true}; | |||
There was a problem hiding this comment.
Did this because typescript complains about nosort not existing
Could have simply removed it, but in case it does exist but there's a typing error...
|
hmm, npm workspaces... |
marcellourbani
force-pushed
the
marcellourbani/issue164
branch
from
a1caa36
to
58d3766
Compare
|
|
|
got rid of workspaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164
Only implemented for native so far, web gives lots of issues with missing modules - I suppose I can replace them with empty ones or something or keep using webpack, as you prefer.
I also added npm workspaces, so all? modules will be installed only once in the project root
Main advantage of this setup is that: