Features spec: only emit a leave if there was an existing matching member #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonWoolf
force-pushed
the
presence-leave
branch
from
60f2cbf to
6873208
Compare
SimonWoolf
force-pushed
the
presence-leave
branch
from
6873208 to
44c7481
Compare
SimonWoolf
added a commit
to ably/ably-js
that referenced
this pull request
Nov 13, 2024
SimonWoolf
added a commit
to ably/ably-js
that referenced
this pull request
Nov 13, 2024
This was referenced Nov 13, 2024
SimonWoolf
added a commit
to ably/ably-js
that referenced
this pull request
Nov 13, 2024
SimonWoolf
force-pushed
the
presence-leave
branch
from
44c7481 to
7634b81
Compare
SimonWoolf
added a commit
to ably/ably-js
that referenced
this pull request
Nov 13, 2024
SimonWoolf
force-pushed
the
presence-leave
branch
from
7634b81 to
bec5b7f
Compare
SimonWoolf
added a commit
to ably/ably-js
that referenced
this pull request
Nov 28, 2024
lawrence-forooghian
approved these changes
Dec 3, 2024
sacOO7
approved these changes
Dec 4, 2024
It's not that urgent, no. Lower priority than the new field names. But it's a pretty small change, so probably worth chucking in the next time someone's making any changes? |
…ng member per #211 The actual behaviour change here is small (only whether non-sync leaves where there is no matching member currently present should emit a leave event), but I found the current structure of this spec section quite confusing (why are broadcast and members-map add/remove requirements defined separately, despite having the same requirements?), so ended up rewriting it. (Without deprecating the old spec items since this isn't actually a behaviour change except in that one case)
SimonWoolf
force-pushed
the
presence-leave
branch
from
bec5b7f to
c4a23ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #211
The actual behaviour change here is small (only whether non-sync leaves where there is no matching member currently present should emit a leave event), but I found the current structure of this spec section a bit confusing (why are broadcast and members-map add/remove requirements defined separately, despite having the same requirements?), so ended up rewriting it. (Without deprecating the old spec items since this isn't actually a behaviour change except in that one case)
change was discussed and agreed at the 2024-11-13 RTF