Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2024 GSoC report Compute Summary for all detected packages #143

Merged
merged 7 commits into from
Aug 24, 2024

Conversation

swastkk
Copy link
Contributor

@swastkk swastkk commented Aug 23, 2024

Add the GSoC 2024 project Compute Summary for all detected packages by swastkk
Signed-off-by: Swastik Sharma [email protected]

Tasks

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Copy link
Collaborator

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes and this will start to look good. Thanks!
For some reason the build is not showing up, linking it here: https://aboutcode--143.org.readthedocs.build/en/143/archive/gsoc/reports/2024/scancode_toolkit_swastkk.html
Also please fix the doc tests from the CI.

--------------

All the work I did is contained in `this single PR <https://github.com/aboutcode-org/scancode-toolkit/pull/3792>`_.
I added a new command-line option called ``--package-summary`` that users can employ to obtain
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have unordered lists here, with a bit more details, use the points in the timeline from your proposal.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add issue links for specific items if they exist. Create issues and ask me to populate the project board as necessary.


This change allows users to get the more refined summary for each individual package
that is present in a codebase. Also this feature improves the package assembly for
various package ecosystems like npm, python-whl, rust, rubygems etc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a bit more detailed, and in an unordered list.

various package ecosystems like npm, python-whl, rust, rubygems etc.


Finally, all these changes are tested through multiple unit tests validating both correct
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't added any unit tests in aboutcode-org/scancode-toolkit#3792 unit tests means tests for a single function, you have added only full scan tests, and have to add unit tests before the PR can be merged. Let's only mention whatever work was completed and move things like this to a section called remaining work/post gsoc. We can always update this page after the work is done.

Copy link
Collaborator

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swastkk Thanks! Looks good for now, we need to update this post-GSoC another time with more details and updates though.

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit ca99049 into aboutcode-org:main Aug 24, 2024
2 checks passed
@AyanSinhaMahapatra
Copy link
Collaborator

Permalink at https://aboutcode.readthedocs.io/en/latest/archive/gsoc/reports/2024/scancode_toolkit_swastkk.html

@swastkk
Copy link
Contributor Author

swastkk commented Aug 24, 2024

@swastkk Thanks! Looks good for now, we need to update this post-GSoC another time with more details and updates though.

Yes, will update this page with more details & updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants