Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom date button renderer and event handlers (month change, popover open) #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mbednarik
Copy link

Closes #33

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chakra-dayzed-datepicker ❌ Failed (Inspect) Nov 22, 2022 at 0:23AM (UTC)

@vercel vercel bot temporarily deployed to Preview November 22, 2022 12:23 Inactive
@mbednarik
Copy link
Author

Hi @aboveyunhai, is the failed deployment something I can help you fix or is the problem not on my side? Thanks

@aboveyunhai
Copy link
Owner

Hi @aboveyunhai, is the failed deployment something I can help you fix or is the problem not on my side? Thanks

nope, it's related to the example folder deployment experiment I did. Expect to fail since the idea won't work. Nothing to do with the code.

@mbednarik
Copy link
Author

Ok, thank you @aboveyunhai. Is there something else you need from me in order to get this merged?

@aboveyunhai
Copy link
Owner

aboveyunhai commented Dec 21, 2022

Ok, thank you @aboveyunhai. Is there something else you need from me in order to get this merged?

I was thinking about something flexible based on the need of this PR without introducing a new prop. The PR might not be merged but the idea and credit will stay here.

Something like but inserting location will be a big challenge, and it might backstab my own foot.

<Datepicker>
    <YourComponent />
</Datepicker>
//or 
<Datepicker>
    {(internalProps) => <YourComponent {you can something with the internal props}/>}
</Datepicker>

@AdsMenezes
Copy link

Add the ability to pass a prop ref to the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom day renderer + month view change event handlers
3 participants