fix: Combining both release-as and prerelease now doesn't break package #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, as shown in conventional-changelog#542, using both options at the same time resulted in the bump file's version being set to null. This was validated in the first of the new unit tests. The other unit tests simply check that the rest of the behavior is correct in this case. With this combination the user can override the version, the purpose of `release-as`, while still starting or continuing a pre-release, the purpose of of the `prerelease`. Fixes conventional-changelog#542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of conventional-changelog#767 , fixes conventional-changelog#542
BEGIN_COMMIT_OVERRIDE
fix: Combining both release-as and prerelease now doesn't break package
END_COMMIT_OVERRIDE
Previously, as shown in conventional-changelog#542, using both options at the same time resulted in the bump file's version being set to null.
This was validated in the first of the new unit tests. The other unit tests simply check that the rest of the behavior is correct in this case.
With this combination the user can override the version, the purpose of
release-as, while still starting or continuing a pre-release, the purpose of of theprerelease.Fixes conventional-changelog#542