Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE-HW1] malloc #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[FE-HW1] malloc #5

wants to merge 3 commits into from

Conversation

malloc3141
Copy link
Collaborator

No description provided.

@malloc3141 malloc3141 self-assigned this Jul 26, 2024
wjeongchoi
wjeongchoi reviewed Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@wjeongchoi wjeongchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 페이지에서 컴포넌트 테스트 해봤나요?? 제가 테스트 해봤을 때는 값이 입력이 안 되는데 확인하고 수정해주세요!

wjeongchoi
wjeongchoi reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@wjeongchoi wjeongchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 입력 잘 되네요! 에러는 어떻게 설정할지도 고민해보면 좋을 것 같아요
그리고 지금은 세미나 과제니까 괜찮지만 Prettier 사용해주면 리뷰하는 사람이 코드 읽기가 편합니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjeongchoi wjeongchoi wjeongchoi left review comments

Assignees

@malloc3141 malloc3141

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malloc3141 @wjeongchoi