feat(decorator): added new methods to extract vocab or non-vocab decorators from model

[DibyamAgrawal]

Added methods to extract vocab/non-vocab decorators, fixed vocabulary parsing bugs, and exposed locale validation method.

Changes

• Added new methods to extract vocab or non-vocab decorators from model
• Fixed some minor bugs related to vocabulary parsing
• Exposed method to validate locale

Flags

Screenshots or Video

Related Issues

Author Checklist

• Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
• Vital features and changes captured in unit and/or integration tests
• Commits messages follow AP format
• Extend the documentation, if necessary
• Merging to main from fork:branchname

[sanketshevkar]

Have you added unit tests to cover the changes that solve the bug fixes?

[DibyamAgrawal]

Have you added unit tests to cover the changes that solve the bug fixes?

Updated the exiting test to check the same by adding the scenarios in the extract-test.cto file.

[sanketshevkar]

LGTM!

[ekarademir]

I think if you recreate the RegEx object at each call, it would be slower than just using startsWith. Is there a reason you want to put the vocabPattern in the function body?

[DibyamAgrawal]

You are correct, we can use startWith instead of regex. Earlier it was having /^Term_/i as vocabPattern to check it in case insensitive manner.

[DibyamAgrawal]

Updated

[ekarademir]

You could have also move the regex to constructor and use the compiled regex. There are trade offs using either

[ekarademir]

Is there a yaml library that we can use instead of directly parsing the string? Maybe not for this PR but that would help a lot.

[DibyamAgrawal]

We can directly create the obj in expected yaml format and use the yaml library to stringify the object or parse the string to yaml obj.

[ekarademir]

shouldn't this return all the decorators?

[DibyamAgrawal]

if removeDecoratorsFromModel is true then it should return undefined to remove all the decorators from the model

[ekarademir]

Is there a disconnect between the Action and the logic then?

[DibyamAgrawal]

The action parameter specifies what to extract from the model (vocab decorators, non-vocab decorators, or both). Meanwhile, removeDecoratorsFromModel flag determines if the decorators should be deleted or not from the model itself after extraction.

[ekarademir]

This function then can be called filterOutDecorators. And then, I think you can just return early if this.removeDecoratorsFromModel is false with the decorators and avoid wrapping the whole function definition in an if statement.

Otherwise it looks like the code is looking like doing the opposite of what the function is aiming to do.

[DibyamAgrawal]

Updated

[ekarademir]

Suggested change

	return decorators.filter((dcs) => {
	return !this.isVocabDecorator(dcs.name);
	});
	return decorators.filter((dcs) => !this.isVocabDecorator(dcs.name);
	);

[DibyamAgrawal]

Updated similar changes