Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm workspaces and bug fixes #912

Merged
merged 27 commits into from
Sep 26, 2024
Merged

npm workspaces and bug fixes #912

merged 27 commits into from
Sep 26, 2024

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Sep 24, 2024 •
edited
Loading

Closes #908

Verifies that for decorator arguments that reference types those types actually exist.

Changes

  • Updates Decorator.validate
  • Unit tests (positive and negative)
  • Removes Lerna and moves to npm workspaces for build
  • Removes axios and colors from concerto-util to decrease size of bundle and improve webpacking
  • Updates concerto-metamodel to 3.10.1

Flags

  • Could break some existing models that have not imported their types but reference them in decorators.

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@dselman
Merge branch 'main' into ds-validate-decorator-typeref
94715cc
@dselman
chore(workflow): update steps
be9805a 
Signed-off-by: Dan Selman <[email protected]>
@dselman
chore(workflow): update steps
9a5e312 
Signed-off-by: Dan Selman <[email protected]>
@dselman
chore(workflow): update steps
945f909 
Signed-off-by: Dan Selman <[email protected]>
@dselman
chore(build): update npm
4e48771 
Signed-off-by: Dan Selman <[email protected]>
@dselman
chore(build): update npm
50e6763 
Signed-off-by: Dan Selman <[email protected]>
@dselman
debugging ci/cd
191f7f1 
Signed-off-by: Dan Selman <[email protected]>
@dselman
debugging ci/cd
379ae7d 
Signed-off-by: Dan Selman <[email protected]>
@dselman
chore(build): update to use npm workspace
95f08b5 
Signed-off-by: Dan Selman <[email protected]>
@dselman
chore(debug) npm ci
01eb7a7 
Signed-off-by: Dan Selman <[email protected]>
@dselman
chore(debug) npm ci
b240712 
Signed-off-by: Dan Selman <[email protected]>
@dselman
chore(debug) npm ci
b1bc3c8 
Signed-off-by: Dan Selman <[email protected]>
@dselman
chore(debug) npm ci
c050783 
Signed-off-by: Dan Selman <[email protected]>
@dselman
chore(debug) npm ci
7a4fa02 
Signed-off-by: Dan Selman <[email protected]>
@dselman
fix(package-lock): remove docusign proxy
14a22c9 
Signed-off-by: Dan Selman <[email protected]>
@dselman
webpack
5679258 
Signed-off-by: Dan Selman <[email protected]>
@dselman
webpack
ca6c139 
Signed-off-by: Dan Selman <[email protected]>
@dselman
remove axios and colors
6e5c695 
Signed-off-by: Dan Selman <[email protected]>
@dselman
matrix
2b783cb 
Signed-off-by: Dan Selman <[email protected]>
@dselman
changed error message
106e6ad 
Signed-off-by: Dan Selman <[email protected]>
@dselman
update publish
104b886 
Signed-off-by: Dan Selman <[email protected]>
@dselman
update publish
deafdee 
Signed-off-by: Dan Selman <[email protected]>
@dselman
update publish
233ab08 
Signed-off-by: Dan Selman <[email protected]>
@dselman
update publish
a6b4be2 
Signed-off-by: Dan Selman <[email protected]>
@dselman
update publish
c631861 
Signed-off-by: Dan Selman <[email protected]>
@dselman dselman changed the title Validate decorators type references npm workspaces and bug fixes Sep 26, 2024
@dselman dselman merged commit 61fdc5a into main Sep 26, 2024
11 checks passed
@dselman dselman deleted the ds-validate-decorator-typeref branch September 26, 2024 17:30
dselman added a commit that referenced this pull request Oct 8, 2024
@dselman
npm workspaces and bug fixes (#912)
7ccd068 
* fix(decorator): validate type references
* chore(deps): update concerto-metamodel to 3.10.1
* chore(npm): move to npm workspaces
* chore(concerto-util): remove axios and colors

Signed-off-by: Dan Selman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decorators can reference concepts that are not imported
2 participants
@dselman @mttrbrts