fixes: #405 Formatted the code using prettier #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Add workflow to build and deploy to S3 Signed-off-by: Martin Halford <[email protected]> * Add workflow to build and deploy to S3 Signed-off-by: Martin Halford <[email protected]> * Add workflow to build and deploy to S3 Signed-off-by: Martin Halford <[email protected]> Signed-off-by: Aashima wadhwa <[email protected]>
Signed-off-by: Aashima wadhwa <[email protected]>
jolanglinais
suggested changes
Feb 11, 2022
There was a problem hiding this comment.
Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
Signed-off-by: aashimawadhwa <[email protected]> Signed-off-by: Aashima wadhwa <[email protected]>
Signed-off-by: aashimawadhwa <[email protected]> Signed-off-by: Aashima wadhwa <[email protected]>
Signed-off-by: aashimawadhwa <[email protected]> Signed-off-by: Aashima wadhwa <[email protected]>
…ansform Signed-off-by: aashimawadhwa <[email protected]> Signed-off-by: Aashima wadhwa <[email protected]>
Signed-off-by: aashimawadhwa <[email protected]>
|
I tried my level best to solve this , I signed all the commits but the last one is always left out , please help me out @irmerk |
|
If you're unable to solve it, I would recommend just starting a new branch and ensuring you put the signoff on the commit(s) when you begin and open a new PR. So when you commit: |
should I close this PR and create a new one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #405
formatted the code using prettier and added required packages
Changes
formats every
*.jsor*.jsxfile in the “scripts/”Related Issues
Author Checklist
--signoffoption of git commit.masterfromfork : master