Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cicero UI -> Web Components #428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cicero UI -> Web Components #428

wants to merge 1 commit into from

Conversation

subhajit20
Copy link

Closes #

Changes

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

@subhajit20
Copy link
Author

hey @irmerk can you review my pr and let me know if any further changes needed?

mttrbrts
mttrbrts requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the Slack changes. The docs should point to Discord now.

@subhajit20
Remove slack changes
add0150 
Signed-off-by: Subhajit Ghosh <[email protected]>
@subhajit20
Copy link
Author

Please revert the Slack changes. The docs should point to Discord now.

Hey done that!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts Awaiting requested review from mttrbrts

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subhajit20 @mttrbrts