Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACF Link to the Navbar #353

Closed

Conversation

YoshithaRathnayake
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake commented Jan 16, 2022

Purpose

The purpose of this PR is to fix #352

Goals

Adding the ACF link to the navbar.

Approach

I added the acf link to the navbar.

Screenshots

image

Preview Link

https://yoshitha-sack.github.io/sack-site/

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Piumal1999 Piumal1999 added the question Further information is requested label Jan 16, 2022
@YoshithaRathnayake YoshithaRathnayake changed the title Add ACF Link to the Navbar. Add ACF Link to the Navbar Jan 17, 2022
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should come under a new menu named Societies.

And it should be Computer Fraternity not ACF

@YoshithaRathnayake
Copy link
Member Author

So I should make a dropdown right ?

@Piumal1999 Piumal1999 removed the question Further information is requested label Jan 26, 2022
@Piumal1999
Copy link
Member

So I should make a dropdown right ?

Yeah @Yoshitha-SACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a dropdown as SOCIETIES
3 participants