Re-use AppleRecv.icns as NetworkBoot.icns; add NetworkBoot labels #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use the same icon for AppleRecv, FirmwareSettings and NetworkBoot. These all have some conceptual similarity (all used for some sort of recovery), and the icon looks right. This could possibly be better captured by the flavours for all three having a shared value (e.g. GenericRecv) somewhere in each flavour list, in which case we would only need one copy of this icon, with this name. This is complicated by the fact that APPLE flavour lists end up with each flavour name duplicated, adding the OS version to one duplicate, but this could be handled (e.g. by only duplicating flavour names beginning with "Apple").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds icon and label files for network boot acidanthera/OpenCorePkg#549 .
We would also need voice-over support files for "Network Boot".
We now use the same icon for AppleRecv, FirmwareSettings and NetworkBoot. These all have some conceptual similarity (all used for some sort of recovery), and the icon looks right.
This could possibly be better captured by the flavours for all three having a shared value (e.g. GenericRecv) somewhere in each flavour list, in which case we would only need one copy of this icon, with this name. This is complicated by the fact that APPLE flavour lists end up with each flavour name duplicated, adding the OS version to one duplicate, but this could be handled (e.g. by only duplicating flavour names beginning with "Apple").
EDIT: It's also not clear whether we'd want "AppleRecv:GenericRecv:Apple" or "AppleRecv:Apple:GenericRecv", if doing the above (remembering that flavour priority is from left to right); both have disadvantages. Keeping the three icons separate (even though the same graphics in our flavour packs) has the advantage of avoiding this issue...