-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement legacy OS booting support #482
Conversation
This feature exists in rEFInd. I'm glad to see it coming to OpenCore. It involves writing to the MBR to change the active partition. This assumes the boot code in the MBR supports the MBR partition table semantics but I don't know of a case where an MBR wouldn't have a partition table. |
USB emulation mode should only be disabled for regular OpenDuet build, and not BlockIoDxe one.
@@ -714,12 +714,25 @@ InternalAddBootEntryFromCustomEntry ( | |||
DEBUG_INFO, | |||
"OCB: Adding custom entry %s (%a|B:%d) -> %a\n", | |||
BootEntry->Name, | |||
CustomEntry->SystemAction != NULL ? "action" : (CustomEntry->Tool ? "tool" : "os"), | |||
CustomEntry->ExternalSystemAction != NULL ? "ext-action" : (CustomEntry->SystemAction != NULL ? "action" : (CustomEntry->Tool ? "tool" : "os")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need icon update in OcBinaryData?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flavor still needs to be set like for SystemAction, currently OC_FLAVOUR_WINDOWS is used for all entries at the moment. Shouldn't need any icon updates.
This looks architecturally right to me. Let's get it merged in the September release, cc @mhaeuser |
In my opinion, this is ready. @Goldfish64, can you merge it please? |
I have just tested it. The Windows (Legacy) logo appears in the bootlicker, but it can't boot. It boots fine through the Apple BootPicker menu. |
Adds support for booting of legacy OSes such as older versions of Windows or situations where legacy Windows must be used for proper functionality of hardware. Scope includes both Macs (via legacy interface) and OpenDuet on PC systems.
Closes acidanthera/bugtracker#912.
Mac
PC
Make USB be in usable state for real mode (transition ownership back to BIOS)Use BlockIo build of DUETPC and Mac