Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OcVariableLib: Add option to set bs-only var ShimLockGuid:ShimRetainProtocol #483

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

mikebeaton
Copy link
Contributor

@mikebeaton mikebeaton commented Aug 30, 2023

If set by bootloader chained from shim before further image is loaded, instructs shim to keep its protocol and its security overrides (if enabled) present for all image loads, not just the first.

May be of more use with additional scripts to be added in ShimUtils (along with shim-to-cert), but works as stated now.

Think this should be okay as is, but not sure if anyone wants to quickly scan for anything. E.g.:

  • Could have split into a new library, but seems overkill.
  • Don't think there are any issues in including this small amount of shim-related stuff, but thought should check before pushing.

Copy link
Member

@mhaeuser mhaeuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm

Library/OcVariableLib/Shim.c Outdated Show resolved Hide resolved
Include/Grub2/ShimVars.h Outdated Show resolved Hide resolved
…rotocol

If set by bootloader chained from shim before further image is loaded, instructs
shim to keep its protocol and its security overrides (if enabled) present for all
image loads, not just the first.
@mikebeaton mikebeaton merged commit 2bbda9d into acidanthera:master Aug 31, 2023
11 checks passed
@mikebeaton mikebeaton deleted the shim-retain-protocol branch August 31, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants