Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close file pointer before calling abort #487

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Close file pointer before calling abort #487

merged 1 commit into from
Sep 27, 2023

Conversation

rilysh
Copy link
Contributor

@rilysh rilysh commented Sep 22, 2023

Hi.
This is a nitpick, but before calling abort in fwrite(...), the UserWriteFile(...) function doesn't close the file pointer, which will cause a memory leak. This PR adds fclose(...) before the abort.

@PMheart PMheart merged commit 9870667 into acidanthera:master Sep 27, 2023
10 of 11 checks passed
@PMheart
Copy link
Member

PMheart commented Sep 27, 2023

Great reminder. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PMheart PMheart Awaiting requested review from PMheart

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rilysh @PMheart