Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCorePkg/OpenDuetPkg: Remove non-needed presence of libraries in Components section #556

Closed

Conversation

mikebeaton
Copy link
Contributor

Spotted while working on #555.

It looks like these lines have always been harmless but not needed.

@mikebeaton
Copy link
Contributor Author

I found this https://github.com/acidanthera/audk/blob/master/CryptoPkg/CryptoPkg.dsc#L354-L361:

#
# If profile is ALL, then do verification build of all library instances.
#
!if $(CRYPTO_SERVICES) == ALL
[Components]
  #
  # Build verification of all library instances
  #
.
.
.

which seems relevant - though I cannot see what is verified except libraries that would not otherwise have been used, or libraries that would have been used and verified anyway.

Searching for +[A-Za-z]*/.*Library/ in *.dsc shows a lot of instance of libraries (?) in Components section. Some are DXE_DRIVER, PEIM, DXE_RUNTIME_DRIVER, etc., but quite a few are BASE, as applies in this change - so am unsure if I'm missing something obvious about why these do something useful.

@mikebeaton
Copy link
Contributor Author

Okay, closing this again, on the general advice that there are 'reasons' for this.... not least allowing testing of libraries which a package provides, but may not consume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant