DebugLib: Simplify DEBUG and ASSERT macros used when MDEPKG_NDEBUG is defined #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This passes all CI on audk, and (after this change acidanthera/OpenCorePkg@fc9a5ec, which makes sense anyway, but was interfering with this) all CI on OpenCorePkg too. |
mikebeaton
force-pushed
the
alt-debug2
branch
from
892bba0
to
2bba588
Compare
mikebeaton
changed the title
… defined The variants provided when MDEPKG_NDEBUG is defined will be optimised away in RELEASE builds, but by referencing the argument (or argument list, in the case of DEBUG) avoid unused variable errors from valid debug code, for example when STATIC variables are used only in DEBUG statements.
mikebeaton
force-pushed
the
alt-debug2
branch
from
2bba588
to
e51362e
Compare
mikebeaton
changed the title
vit9696
approved these changes
Dec 14, 2023
MikhailKrichanov
approved these changes
Dec 14, 2023
MikhailKrichanov
pushed a commit
that referenced
this pull request
Dec 15, 2023
Azure should install code coverage tool (lcov), it didn't exist on Fedora and Ubuntu by default. Update docker setting, pick below solution between 47addc9 and 3b3eb8f 3b3eb8f Fixes and improvements to dev containers (#69) 54e5bd1 Enable GTK on Fedora QEMU (#63) f1c7a20 Fedora: install code coverage tools for GCC (#62) 2ce82af Ubuntu-22: Add initial Ubuntu-22 image (#61) 14d2aba Add Fedora 37 image with gcc12 (#60) 5b8a008 Add dotnet runtime to fedora build (#57) f5c874a Fix platform build file name for EDK2 change (#58) 48540ad Ubuntu-20: Fix dev image entrypoint (#55) 98e849d Fedora-35: Add Powershell to build image (#52) Cc: Michael D Kinney <[email protected]> Cc: Sean Brogan <[email protected]> Cc: Michael Kubacki <[email protected]> Cc: Oliver Steffen <[email protected]> Cc: Chris Fernald <[email protected]> Signed-off-by: Gua Guo <[email protected]> Reviewed-by: Michael D Kinney <[email protected]> Reviewed-by: Michael Kubacki <[email protected]> Reviewed-by: Chris Fernald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variants provided when MDEPKG_NDEBUG is defined will be optimised away in RELEASE builds, but by referencing the argument (or argument list, in the case of DEBUG) avoid unused variable errors from valid debug code, for example when STATIC variables are used only in DEBUG statements.