UE/PE FV/NON-FV fixes - see commit comments #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bool bug in an earlier version, which unfortunately inverted the sense of this check, but the correct (and secure) fix is to continue to enforce the check, using the enum valuues. Signed-off-by: Mike Beaton <[email protected]> Signed-off-by: Marvin Häuser <[email protected]>
mhaeuser
approved these changes
Apr 22, 2024
|
I think allowing UE for FV is missing now for OVMF, but CI will let you know. :) @MikhailKrichanov As usual, this may break Amaranth… |
mikebeaton
force-pushed
the
fv-fix
branch
4 times, most recently
from
ee4a64a
to
1451d24
Compare
Updated. |
…N_FV UE is experimental and non-standard, so should not be supported by default. For platforms that opt in to UE, like OVMF and DUET, globally for the platform (not overridden per-module) the FV PCD should either be PE | UE or only UE, depending on where support is at. Signed-off-by: Mike Beaton <[email protected]> Signed-off-by: Marvin Häuser <[email protected]>
MikhailKrichanov
approved these changes
Apr 24, 2024
mhaeuser
approved these changes
Apr 24, 2024
vit9696
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with acidanthera/OpenCorePkg#536