Skip to content

Commit

Permalink
feat: source sidekiq-batch from GitHub repository (#654)
Browse files Browse the repository at this point in the history
Support for Sidekiq v7 has been landed in the repository
(breamware/sidekiq-batch#89 &
breamware/sidekiq-batch#85), but not yet
released - hopefully that'll happen soon, but in the meantime I'm
switching us to pull from the repository because
1. it sounds like that includes some further fixes which might be useful
to us
2. the ubuntu-24 stack on Heroku no longer has `git` at runtime which
looks to be causing our deployment to fail because
`sidekiq-batch.gemspec` tries to do `git ls-remote -z` for determining
the files to include; we might still run into issues because we're
technically still using `git`, but I'm hoping this moves our usage into
the "build" phase where `git` should still be available...
  • Loading branch information
G-Rath authored Jul 21, 2024
1 parent 2151c7d commit d94f337
Show file tree
Hide file tree
Showing 28 changed files with 5 additions and 1,772 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ gem "raygun4ruby"
gem "redis"
gem "sassc-rails"
gem "sidekiq"
gem "sidekiq-batch", path: "vendor/gems/sidekiq-batch"
gem "sidekiq-batch", github: "breamware/sidekiq-batch" # required for sidekiq v7, as changes have not yet been released
gem "sqlite3"
gem "turbolinks"
gem "webpacker", "~> 5.0"
Expand Down
7 changes: 4 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
PATH
remote: vendor/gems/sidekiq-batch
GIT
remote: https://github.com/breamware/sidekiq-batch.git
revision: f2ef0289ea23e652797741de96506957535099ff
specs:
sidekiq-batch (0.1.9)
sidekiq (>= 3, < 8)
sidekiq (>= 7, < 8)

GEM
remote: https://rubygems.org/
Expand Down
2 changes: 0 additions & 2 deletions vendor/gems/sidekiq-batch/.rspec

This file was deleted.

7 changes: 0 additions & 7 deletions vendor/gems/sidekiq-batch/.travis.yml

This file was deleted.

8 changes: 0 additions & 8 deletions vendor/gems/sidekiq-batch/Gemfile

This file was deleted.

4 changes: 0 additions & 4 deletions vendor/gems/sidekiq-batch/Guardfile

This file was deleted.

21 changes: 0 additions & 21 deletions vendor/gems/sidekiq-batch/LICENSE.txt

This file was deleted.

78 changes: 0 additions & 78 deletions vendor/gems/sidekiq-batch/README.md

This file was deleted.

6 changes: 0 additions & 6 deletions vendor/gems/sidekiq-batch/Rakefile

This file was deleted.

Loading

0 comments on commit d94f337

Please sign in to comment.