use backend support for whether onboarding seen

acmucsd · Nov 5, 2024 · 0e0a00e · 0e0a00e
1 parent 1282c47
commit 0e0a00e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/src/lib/types/apiRequests.ts b/src/lib/types/apiRequests.ts
@@ -77,6 +77,7 @@ export interface UserPatches {
   graduationYear?: number;
   bio?: string;
   isAttendancePublic?: boolean;
+  onboardingSeen?: boolean;
   passwordChange?: PasswordUpdate;
 }
 

diff --git a/src/lib/types/apiResponses.ts b/src/lib/types/apiResponses.ts
@@ -382,6 +382,7 @@ export interface PrivateProfile extends PublicProfile {
   state: UserState;
   credits: number;
   resumes?: PublicResume[];
+  onboardingSeen: boolean;
 }
 
 export interface PublicFeedback {

diff --git a/src/pages/index.tsx b/src/pages/index.tsx
@@ -99,11 +99,7 @@ const PortalHomePage = ({
           // Start onboarding after checking in
           // TEMP: This should be saved server-side in the future
           // Do not start onboarding if user already attended other events
-          if (attendance.length > 1) {
-            return;
-          }
-          const onboardingState = localStorage.getItem(config.tempLocalOnboardingKey);
-          if (onboardingState === 'onboarded') {
+          if (user.onboardingSeen) {
             return;
           }
           router.push(

diff --git a/src/pages/onboard.tsx b/src/pages/onboard.tsx
@@ -1,5 +1,6 @@
 import { OnboardingScreen } from '@/components/onboarding';
 import { config } from '@/lib';
+import { UserAPI } from '@/lib/api';
 import withAccessType, { GetServerSidePropsWithAuth } from '@/lib/hoc/withAccessType';
 import { PermissionService } from '@/lib/services';
 import { URL } from '@/lib/types';
@@ -9,10 +10,11 @@ import { useRouter } from 'next/router';
 
 interface OnboardProps {
   destination: URL;
+  authToken: string;
   user: PrivateProfile;
 }
 
-const OnboardPage: NextPage<OnboardProps> = ({ user, destination }) => {
+const OnboardPage: NextPage<OnboardProps> = ({ authToken, user, destination }) => {
   const router = useRouter();
 
   const handleExit = () => {
@@ -25,7 +27,7 @@ const OnboardPage: NextPage<OnboardProps> = ({ user, destination }) => {
         user={user}
         onDismiss={handleExit}
         onFinish={() => {
-          localStorage.setItem(config.tempLocalOnboardingKey, 'onboarded');
+          UserAPI.updateCurrentUserProfile(authToken, { onboardingSeen: true });
         }}
       />
     </div>
@@ -34,12 +36,13 @@ const OnboardPage: NextPage<OnboardProps> = ({ user, destination }) => {
 
 export default OnboardPage;
 
-const getServerSidePropsFunc: GetServerSidePropsWithAuth = async ({ query }) => {
+const getServerSidePropsFunc: GetServerSidePropsWithAuth = async ({ query, authToken }) => {
   const route = query?.destination ? decodeURIComponent(query?.destination as string) : null;
 
   return {
     props: {
       destination: route || config.homeRoute,
+      authToken,
       quietNavbar: true,
     },
   };