Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce onboarding frequency #266

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Reduce onboarding frequency #266

merged 2 commits into from
Oct 25, 2024

Conversation

SheepTester
Copy link
Member

@SheepTester SheepTester commented Oct 21, 2024

Info

Don't show onboarding when user has already attended events

People are regularly seeing onboarding reappear because their devices seem to regularly clear cookies (particularly on iOS). Since kickoff already happened, it's probably fine if onboarding doesn't show up as often anymore. And we don't want users to be numb to it when backend support finally arrives with tasks

Note that one consequence of this change is that a new user who clicks "maybe later" on onboarding will never see it again until backend support is implemented. i think that's probably fine for now

Changes

  • In order for onboarding to appear, it now checks that the user has only attended at most one event (probably the event they just checked into) when they close the checkin modal

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 2:20am
testing-membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 2:20am

@SheepTester SheepTester merged commit f2a8736 into main Oct 25, 2024
8 checks passed
@SheepTester SheepTester deleted the sean/reduce-onboarding branch October 25, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants