-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search leaderboard and scroll to your position #69
Conversation
You can't test this because ACM Admin isn't on the leaderboard
Removed smooth scrolling since the animation could finish before you scroll to the element
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Might want design feedback on this implementation but I think keeping the top 3 cards is a little funky while the search query is filtering the items. I'd prefer rendering the top 3 as standard list items when the search is non-empty. |
That's a pretty good idea, I think it looks better that way 2023-08-22.19-19-17.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Info
Closes #62. (If there is no issue for this pull request yet, please create one or
delete this line if the pull request is for a very minor tweak).
This should not conflict with #68 (they unambiguously change different parts of the file).
Description
What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.
I added a search bar to filter the leaderboard rows by a query and a button that scrolls to your row in the leaderboard (if it exists and isn't in the top three)
Changes
Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
src/lib
functions and commented hard to understand areasanywhere else.
Screenshots
Please include a screenshot of your Cypress testing suite passing successfully.
If you made any visual changes to the website, please include relevant screenshots below.
Here's a video showing searching and scrolling to your position. Note that I added the second Ryan Truong manually because the test account isn't on the leaderboard.
2023-08-22.17-00-32.mp4