Get another user's event attendance #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwn04
requested review from
sumeet-bansal,
shravanhariharan2 and
dowhep
as code owners
|
Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate. |
|
|
dowhep
changed the title
shravanhariharan2
previously requested changes
Aug 13, 2023
dowhep
requested changes
Nov 27, 2023
tests/attendance.test.ts
Outdated
| @@ -272,4 +272,58 @@ describe('attendance', () => { | |||
| expect(attendance.user.uuid).toEqual(staff.uuid); | |||
| expect(attendance.event.uuid).toEqual(event.uuid); | |||
| }); | |||
|
|
|||
| test('get user attendance by uuid', async () => { | |||
There was a problem hiding this comment.
Let's rename this to 'get another user's attendance by uuid' for clarification
tests/attendance.test.ts
Outdated
| expect(attendancesForEvent).toEqual(expect.arrayContaining(expectedAttendances)); | ||
| }); | ||
|
|
||
| test('throws error when canSeeAttendanceFalse', async () => { |
There was a problem hiding this comment.
instead of canSeeAttendanceFalse, let's update the test description to "throws error when isAttendancePublilc is false"
…ucsd/membership-portal into Max/get-user-past-attendance
dowhep
added
the
Hold Off On Merge
|
Ok so there are some issues we found on this branch during our test on the staging environment that Nikhil has set up - so far the users cannot see whether they have We should include |
…into Max/get-user-past-attendance merging from master
…ucsd/membership-portal into Max/get-user-past-attendance merging in latest max commits
nik-dange
approved these changes
Dec 31, 2023
dowhep
added a commit
that referenced
this pull request
Dec 31, 2023
* started migration * almost completed the query * change MerchandiseItemModel picture to pictures * renamed Merchandise to MercahndiseItems * generated a new model for the pictures * fixed syntax error with migration * understand and fix casting error * edited requests and created some todos * return position == 0 instead of first picture in array * migration temp fix * this one line of code would attach pictures to the collection so that the frontend can display the first picture * edited some todos to implement a new idea * edited the service * created a repository for photos * Completed the photo create route * completed the photo deletion route * getting started with seeding * make sure the index is consistent * removed the current file name from url for security purpose * quick linting * edited seeding to ensure correctness * update MerchFactory item for photo support * refactor and renaming variables * wrote outline for test and rewrote a method * fix error * edits * removing some junk code * the error is playing hide and seek with me * im such a genius * removing partial debug msgs * edits * fixed the order item test * finished creating tests and pass all tests * fixed some error * I CHATGPTED THE SQL AND IT WORKED * fixed linting error * edit migration number order * clean up some unused variables * renamed picture to uploadedPhoto and photo to merchPhoto for clarity, added some documentation * remove magic number * slight seeding edit * removed position logic * clarify cascading quetsion * fixed cascade * clean up * clarify seeding data structure * link fix * change position in request to string because form data does not accept number * throw error if position is not a number * updated deletion logic to delete from s3 first * link fix * default url logic fix for positions no longer being 0 * Get another user's event attendance (#358) * attendences from user uuid * lint and bugfix * check same user * controller factory changes * lint fixes * unit test for get attendance by uuid * lint * add permision * add types * add everything else * rename migrtion * test when permision is off * lint * forgor to add * change permission name and fix logic a bit * rename permission, change patch user * lint fix * lint fix * oops * check user exists * lint * rename tests * public profile change * change user model * lint * tests * lint * updated api version --------- Co-authored-by: Nikhil Dange <[email protected]> * staging deployment workflow (#381) * bumped my migration file number * bumped my migration file number v2 * remove local settings.json change * added edge case for migration up * lint * lint --------- Co-authored-by: Max Weng <[email protected]> Co-authored-by: Nikhil Dange <[email protected]> Co-authored-by: Nikhil Dange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gets the users past attendance