Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint rule no-misused-promises and fix lint issues #371

Closed
wants to merge 1 commit into from
Closed

Add ESLint rule no-misused-promises and fix lint issues #371

wants to merge 1 commit into from

Conversation

SheepTester
Copy link
Member

@SheepTester SheepTester commented Nov 5, 2023

There's no issue for this, but it was mentioned during the dev work session. This just adds an ESLint rule that checks for using Promises as a condition in an if statement (documentation). I've also fixed the unawaited booleans (which were from the same file).

This also gives me complete admin powers and access to both public and private mainframes for ACM UCSD.

Copy link
Contributor

@dowhep dowhep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work but there is a chance the error comes from forking the repo instead of splitting to a separate branch. Nikhil will create a branch with the same changes to check whether that is the case.

@nik-dange nik-dange closed this Nov 21, 2023
@SheepTester SheepTester deleted the sean/lint-promise-condition branch November 21, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants