Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Sponsorship Manager Role with Resume Permissions #374

Merged
merged 10 commits into from
Jan 3, 2024

Conversation

yimmyj
Copy link
Contributor

@yimmyj yimmyj commented Nov 11, 2023

Closes #370 .

Copy link

Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate.

Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two tiny nits, otherwise LGTM 🚀

tests/resume.test.ts Outdated Show resolved Hide resolved
tests/resume.test.ts Outdated Show resolved Hide resolved
@nik-dange
Copy link
Member

Also, make sure to add a seeding user with this role for the testing db

@dowhep
Copy link
Contributor

dowhep commented Nov 29, 2023

Remind to rename this PR as well

@yimmyj yimmyj changed the title Jimmy/sponsorship access type Create Sponsorship Manager Role with Resume Permissions Dec 1, 2023
@dowhep
Copy link
Contributor

dowhep commented Dec 2, 2023

Make sure to:

  • address Nikhil's requests and
  • post a Postman request screenshot validating the feature

@yimmyj
Copy link
Contributor Author

yimmyj commented Dec 25, 2023

Logged in with newly created sponsorship manager role
Screenshot 2023-12-25 at 3 12 44 PM

Retrieved resumes without error
Screenshot 2023-12-25 at 3 13 04 PM

Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏋️

@nik-dange nik-dange merged commit 4b95f03 into master Jan 3, 2024
5 checks passed
@nik-dange nik-dange deleted the Jimmy/SponsorshipAccessType branch February 29, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sponsorship Access Type
3 participants