-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: address to bytes32 contract changes #650
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7a5dc8c
feat: add address to bytes32 contract changes
md0x b65940d
refactor: remove todos
md0x 429affc
refactor: imports
md0x 3f92876
Update contracts/SpokePool.sol
md0x 0873145
feat: bytes 32 comparisons
md0x 73f378c
refactor: format code
md0x 1d5a084
Merge branch 'pablo/address-to-bytes32' of ssh://github.com/across-pr…
md0x 8f233fa
fix: tests
md0x 1a1815b
feat: bytes 32 check
md0x 64a2291
fix: ts
md0x 209f645
feat: reuse lib in cctp adapter
md0x 59f294c
feat: _preExecuteLeafHook
md0x 1551d32
Merge branch 'master' into pablo/address-to-bytes32
md0x 74be13c
refactor: comments
md0x 039c323
feat: _verifyUpdateV3DepositMessage
md0x ddfa612
feat: backward compatibility
md0x a20e6ed
Merge branch 'svm-dev' into pablo/address-to-bytes32
md0x 8ee4c76
feat: backwards compatibility tests
md0x 6cd2ea2
feat: change comparison casting address bytes32
md0x 1ea1344
fix: test
md0x c91dcb1
feat: merkle tree leaf to bytes32
md0x 48e4023
test: leaf type update fixes
md0x 8412ca9
feat: remove helper
md0x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: shall we use explicit imports? I see that recent commits have been moving in that direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @Reinis-FRP What do you mean here?
These are imported in the SpokePool.sol and used here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, meant using curly braces to explicitly state what contracts/libraries from source files we are importing