chore(SpokePool): Remove pre-v3 types and events #663
+2
−333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are no longer needed and would potentially otherwise be clobbered by upcoming svm changes. Remove them now to simplify that work.
pxrl
commented
Oct 15, 2024
Comment on lines
-148
to
-178
| function depositV2( | ||
| address recipient, | ||
| address originToken, | ||
| uint256 amount, | ||
| uint256 destinationChainId, | ||
| int64 relayerFeePct, | ||
| uint32 quoteTimestamp, | ||
| bytes memory message, | ||
| uint256 // maxCount | ||
| ) public payable virtual nonReentrant unpausedDeposits { | ||
| // Increment count of deposits so that deposit ID for this spoke pool is unique. | ||
| uint32 newDepositId = numberOfDeposits++; | ||
|
|
||
| if (originToken == address(wrappedNativeToken) && msg.value > 0) { | ||
| require(msg.value == amount); | ||
| wrappedNativeToken.deposit{ value: msg.value }(); | ||
| } else IERC20Upgradeable(originToken).safeTransferFrom(msg.sender, address(this), amount); | ||
|
|
||
| emit FundsDeposited( | ||
| amount, | ||
| chainId(), | ||
| destinationChainId, | ||
| relayerFeePct, | ||
| newDepositId, | ||
| quoteTimestamp, | ||
| originToken, | ||
| recipient, | ||
| msg.sender, | ||
| message | ||
| ); | ||
| } |
There was a problem hiding this comment.
We might want to retain this, tbf.
|
@mrice32 @nicholaspai Are we OK to move on this cleanup? We have a lot of WIP work that would ideally come after it, but those PRs are instead internalising some overlapping changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are no longer needed and would potentially otherwise be clobbered by upcoming svm changes. Remove them now to simplify that work.