-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: supply decimals and CCTP domain in custom token adapter #690
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: bennett <[email protected]>
deploy/consts.ts
Outdated
@@ -48,6 +51,9 @@ export const L1_ADDRESS_MAP: { [key: number]: { [contractName: string]: string } | |||
zoraStandardBridge: "0x3e2Ea9B92B7E48A52296fD261dc26fd995284631", | |||
worldChainCrossDomainMessenger: "0xf931a81D18B1766d15695ffc7c1920a62b7e710a", | |||
worldChainStandardBridge: "0x470458C91978D2d929704489Ad730DC3E3001113", | |||
l1AlephZeroInbox: "0x56D8EC76a421063e1907503aDd3794c395256AEb", | |||
l1AlephZeroERC20GatewayRouter: "0xeBb17f398ed30d02F2e8733e7c1e5cf566e17812", | |||
donationBox: "0x5e40a88E302Da80089Dd13178b8DD6b15534419c", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be swapped out once we deploy an official adapter.
Signed-off-by: bennett <[email protected]>
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is a critical CVE?Contains a Critical Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
deploy/052_deploy_donation_box.ts
Outdated
const { deployer } = await hre.getNamedAccounts(); | ||
|
||
// @note if deploying this contract on a chain like Linea that only supports up to | ||
// solc 0.8.19, the hardhat.config solc version needs to be overridden and this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is outdated - Linea supports later versions of solidity but the evm version must be set to london. See https://docs.linea.build/developers/quickstart/ethereum-differences#evm-opcodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know this. Nice. 8e20183
Signed-off-by: bennett <[email protected]>
Report too large to display inline |
Three changes needed to be made:
nativeTokenDecimals
function we can call, so we instead define the decimals of the native token it in the constructor. We do not resolve this dynamically since decimals is not required to implement ERC20, so we can't rely on IERC20 to calldecimals()
.createRetryableTicket
to bridge the native gas token,l2CallValue
must actually be the amount of the native gas token to send, not zero. This is becausel2CallValue
is with respect to the L2's native token, not ETH.